fix(lorie): rename resources to avoid host collisions#1061
Merged
Conversation
…ions Same-named mipmap/string/style resources (ic_launcher*, app_name, AppTheme) let the host app's version silently win when :lorie is embedded as a library, producing the wrong launcher icon, label and theme.
…ions view_terminal_toolbar_extra_keys.xml, view_terminal_toolbar_text_input.xml and ic_settings.xml collide with same-named termux-app resources; the host's layout won and crashed X11ToolbarViewPager with a ClassCastException (and would NPE on the text-input tab too).
LoriePreferences and TouchInputHandler resolve lorie_pref_*/lorie_notification_* strings via Resources.getIdentifier(), which the shrinker can't see statically, so shrinkResources was stripping them and preference/notification labels went blank.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.