Skip to content

fix: cannot save to local storage of workspace synchronized from collaboration server #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2023

Conversation

thorseraq
Copy link
Contributor

@thorseraq thorseraq commented Apr 19, 2023

close #393

I made some comments in the code base where might worth discussing, please give it a review :)

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 5:58am

@thorseraq thorseraq temporarily deployed to development April 19, 2023 14:14 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development April 19, 2023 14:14 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development April 19, 2023 14:14 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 10.41% and project coverage change: -0.16 ⚠️

Comparison is base (421b8b0) 65.78% compared to head (d50d421) 65.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   65.78%   65.63%   -0.16%     
==========================================
  Files         125      125              
  Lines       12025    12078      +53     
==========================================
+ Hits         7911     7927      +16     
- Misses       4114     4151      +37     
Impacted Files Coverage Δ
apps/keck/src/server/sync/collaboration.rs 0.00% <0.00%> (ø)
libs/jwst-binding/jwst-jni/src/storage.rs 0.00% <0.00%> (ø)
libs/jwst-binding/jwst-swift/src/storage.rs 0.00% <0.00%> (ø)
libs/jwst-rpc/src/client.rs 0.00% <0.00%> (ø)
libs/jwst/src/types/error.rs 0.00% <ø> (ø)
libs/jwst-rpc/src/handler.rs 27.00% <33.33%> (+0.36%) ⬆️
libs/jwst/src/workspace/observe.rs 59.57% <71.42%> (+2.43%) ⬆️
libs/jwst-rpc/src/broadcast.rs 60.25% <100.00%> (+5.32%) ⬆️
...bs/jwst/src/workspace/plugins/indexing/register.rs 89.04% <100.00%> (ø)
libs/jwst/src/workspace/workspace.rs 98.32% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thorseraq thorseraq temporarily deployed to development April 19, 2023 14:36 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development April 19, 2023 14:36 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development April 19, 2023 14:36 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development April 20, 2023 03:32 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development April 20, 2023 03:32 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development April 20, 2023 03:32 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development April 20, 2023 05:58 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development April 20, 2023 05:58 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development April 20, 2023 05:58 — with GitHub Actions Inactive
@darkskygit darkskygit enabled auto-merge (squash) April 20, 2023 05:59
@darkskygit darkskygit merged commit 195d614 into toeverything:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cannot save to local storage of workspace synchronized from collaboration server
2 participants