Skip to content

feat: finish apply update implementation #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented May 23, 2023

In this PR, almost of the apply_update stuff are done.

In this version, the update type dependency is just a simple struct need to be finished when dealing with concrete types(YText/YArray...)

More testings are on the way but this PR is so ready to be reviewed.

@forehalo forehalo added the feat New feature or request label May 23, 2023
@forehalo forehalo added this to the AFFiNE 0.6 milestone May 23, 2023
@forehalo forehalo requested a review from darkskygit May 23, 2023 03:01
@forehalo forehalo self-assigned this May 23, 2023
@vercel
Copy link

vercel bot commented May 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2023 4:28am

@forehalo forehalo temporarily deployed to development May 23, 2023 03:01 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development May 23, 2023 03:01 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 46.28% and project coverage change: -0.39 ⚠️

Comparison is base (5c90e2a) 66.51% compared to head (e311112) 66.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   66.51%   66.13%   -0.39%     
==========================================
  Files         140      143       +3     
  Lines       14007    14774     +767     
==========================================
+ Hits         9317     9771     +454     
- Misses       4690     5003     +313     
Impacted Files Coverage Δ
libs/jwst-codec/src/doc/document.rs 0.00% <0.00%> (-7.65%) ⬇️
libs/jwst-codec/src/doc/types/mod.rs 0.00% <0.00%> (ø)
libs/jwst-codec/src/lib.rs 100.00% <ø> (+62.71%) ⬆️
libs/jwst-codec/src/doc/codec/id.rs 33.33% <11.11%> (-20.52%) ⬇️
libs/jwst-codec/src/doc/codec/item.rs 42.75% <38.82%> (-2.96%) ⬇️
libs/jwst-codec/src/doc/store.rs 71.65% <41.60%> (-13.60%) ⬇️
libs/jwst-codec/src/doc/codec/refs.rs 64.86% <44.73%> (-9.58%) ⬇️
libs/jwst-codec/src/doc/common/range.rs 60.86% <60.86%> (ø)
libs/jwst-codec/src/doc/codec/update.rs 74.86% <72.03%> (+61.28%) ⬆️
libs/jwst-codec/src/doc/codec/delete_set.rs 72.22% <72.22%> (ø)
... and 2 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@forehalo forehalo force-pushed the feat/apply-update branch from 000a76b to e311112 Compare May 23, 2023 04:27
@forehalo forehalo temporarily deployed to development May 23, 2023 04:27 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development May 23, 2023 04:27 — with GitHub Actions Inactive
@forehalo forehalo merged commit df2e4f1 into master May 23, 2023
@forehalo forehalo deleted the feat/apply-update branch May 23, 2023 06:27
@forehalo forehalo mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants