-
-
Notifications
You must be signed in to change notification settings - Fork 115
feat: implement YText #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #440 +/- ##
==========================================
+ Coverage 69.37% 70.76% +1.39%
==========================================
Files 144 146 +2
Lines 15337 15750 +413
==========================================
+ Hits 10640 11146 +506
+ Misses 4697 4604 -93
☔ View full report in Codecov by Sentry. |
This is a fast implementation for YText without performance optimization.
We will compare it with List implementation and see if we could abstract the common part into traits or whatever.
Performance notice: