Skip to content

refactor: fast left/right item dereference #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Jun 7, 2023

No description provided.

@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase 🛑 Canceled (Inspect) Jun 8, 2023 9:27am

@forehalo forehalo temporarily deployed to development June 7, 2023 10:29 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 7, 2023 10:29 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 7, 2023 10:29 — with GitHub Actions Inactive
@forehalo forehalo force-pushed the refactor/fast-item-dereference branch from 5ae78cd to cda85c7 Compare June 8, 2023 02:41
@forehalo forehalo temporarily deployed to development June 8, 2023 02:41 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 8, 2023 02:41 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 8, 2023 02:41 — with GitHub Actions Inactive
@forehalo forehalo force-pushed the refactor/fast-item-dereference branch from cda85c7 to 763fcc7 Compare June 8, 2023 03:07
@forehalo forehalo temporarily deployed to development June 8, 2023 03:07 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 8, 2023 03:07 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 8, 2023 03:07 — with GitHub Actions Inactive
@forehalo forehalo force-pushed the refactor/fast-item-dereference branch from f639d46 to c7dada3 Compare June 8, 2023 09:26
@forehalo forehalo temporarily deployed to development June 8, 2023 09:26 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 8, 2023 09:26 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 8, 2023 09:26 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 68.85% and project coverage change: +0.32 🎉

Comparison is base (fd65274) 68.96% compared to head (c7dada3) 69.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   68.96%   69.28%   +0.32%     
==========================================
  Files         160      160              
  Lines       17433    17460      +27     
==========================================
+ Hits        12022    12098      +76     
+ Misses       5411     5362      -49     
Impacted Files Coverage Δ
libs/jwst-codec/src/doc/codec/id.rs 85.71% <0.00%> (-6.60%) ⬇️
libs/jwst-codec/src/doc/types/array.rs 61.68% <ø> (ø)
libs/jwst-codec/src/doc/codec/item.rs 75.34% <40.00%> (-7.86%) ⬇️
libs/jwst-codec/src/doc/codec/refs.rs 86.41% <63.15%> (-4.03%) ⬇️
libs/jwst-codec/src/doc/store.rs 79.30% <64.42%> (+1.51%) ⬆️
...ibs/jwst-codec/src/doc/types/list/search_marker.rs 83.87% <81.42%> (-0.26%) ⬇️
libs/jwst-codec/src/doc/types/mod.rs 80.14% <83.33%> (+0.70%) ⬆️
libs/jwst-codec/src/doc/types/list/mod.rs 89.41% <90.24%> (-1.79%) ⬇️
libs/jwst-codec/src/doc/codec/update.rs 78.80% <100.00%> (ø)
libs/jwst-codec/src/doc/codec/utils/items.rs 100.00% <100.00%> (ø)
... and 3 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@darkskygit darkskygit merged commit ea98877 into master Jun 8, 2023
@darkskygit darkskygit deleted the refactor/fast-item-dereference branch June 8, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants