Skip to content

feat: Implement BlobStorage for BlobBucketDBStorage #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Jun 21, 2023

Fix #464

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 10:14am

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo temporarily deployed to development June 21, 2023 09:15 — with GitHub Actions Inactive
@Xuanwo Xuanwo temporarily deployed to development June 21, 2023 09:15 — with GitHub Actions Inactive
@Xuanwo Xuanwo temporarily deployed to development June 21, 2023 09:15 — with GitHub Actions Inactive
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jun 21, 2023

Hi @thorseraq, would you be willing to review for me? Thank you.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (c1c0a9f) 69.42% compared to head (a6f4002) 69.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
- Coverage   69.42%   69.38%   -0.05%     
==========================================
  Files         164      164              
  Lines       17974    18001      +27     
==========================================
+ Hits        12479    12490      +11     
- Misses       5495     5511      +16     
Impacted Files Coverage Δ
.../jwst-storage/src/storage/blobs/bucket_local_db.rs 0.00% <0.00%> (ø)
libs/jwst-storage/src/storage/blobs/utils.rs 87.77% <0.00%> (-5.17%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xuanwo Xuanwo temporarily deployed to development June 21, 2023 10:13 — with GitHub Actions Inactive
@Xuanwo Xuanwo temporarily deployed to development June 21, 2023 10:13 — with GitHub Actions Inactive
@Xuanwo Xuanwo temporarily deployed to development June 21, 2023 10:13 — with GitHub Actions Inactive
@thorseraq
Copy link
Contributor

Thanks! So fast for another PR!

@thorseraq thorseraq merged commit 24b372b into toeverything:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

impl BlobStorage for BucketStorage
2 participants