Skip to content

fix: ensure store exists in ytype #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

darkskygit
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 7:54am

@darkskygit darkskygit temporarily deployed to development August 10, 2023 07:53 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development August 10, 2023 07:53 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development August 10, 2023 07:53 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (d6a6d38) 65.47% compared to head (a78aa30) 65.47%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   65.47%   65.47%   -0.01%     
==========================================
  Files         164      164              
  Lines       19739    19744       +5     
==========================================
+ Hits        12925    12927       +2     
- Misses       6814     6817       +3     
Files Changed Coverage Δ
libs/jwst-codec/src/doc/store.rs 84.16% <100.00%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo enabled auto-merge (squash) August 10, 2023 08:23
@github-actions
Copy link

Benchmark Results

Linux

group                                     master                                 pr
-----                                     ------                                 --
codec/jwst decode var_int (32 bit)        1.00    326.7±3.42µs        ? ?/sec    1.02    331.6±8.93µs        ? ?/sec
codec/jwst decode var_int (64 bit)        1.00    365.4±5.80µs        ? ?/sec    1.02    371.8±5.97µs        ? ?/sec
codec/jwst decode var_uint (32 bit)       1.00    273.7±1.99µs        ? ?/sec    1.00    273.7±0.96µs        ? ?/sec
codec/jwst decode var_uint (64 bit)       1.01    297.0±5.08µs        ? ?/sec    1.00    295.0±3.67µs        ? ?/sec
codec/jwst encode var_int (32 bit)        1.00    472.7±1.07µs        ? ?/sec    1.00    472.8±1.07µs        ? ?/sec
codec/jwst encode var_int (64 bit)        1.00    507.7±5.42µs        ? ?/sec    1.01    510.7±5.09µs        ? ?/sec
codec/jwst encode var_uint (32 bit)       1.00    377.5±0.97µs        ? ?/sec    1.00    377.4±0.95µs        ? ?/sec
codec/jwst encode var_uint (64 bit)       1.00    377.5±0.93µs        ? ?/sec    1.01    381.4±3.91µs        ? ?/sec
codec/lib0 decode var_int (64 bit)        1.02    291.5±8.61µs        ? ?/sec    1.00    286.1±6.95µs        ? ?/sec
codec/lib0 decode var_uint (32 bit)       1.01    239.5±4.22µs        ? ?/sec    1.00    238.2±3.94µs        ? ?/sec
codec/lib0 decode var_uint (64 bit)       1.01    239.4±2.89µs        ? ?/sec    1.00    237.1±2.93µs        ? ?/sec
codec/lib0 encode var_int (64 bit)        1.02   466.2±14.35µs        ? ?/sec    1.00   457.0±10.82µs        ? ?/sec
codec/lib0 encode var_uint (32 bit)       1.00    385.1±1.51µs        ? ?/sec    1.04    402.3±5.20µs        ? ?/sec
codec/lib0 encode var_uint (64 bit)       1.00    342.1±0.73µs        ? ?/sec    1.00    342.2±0.61µs        ? ?/sec
ops/array/jwst/insert                     1.00    394.0±0.36µs        ? ?/sec    1.00    394.6±1.20µs        ? ?/sec
ops/array/jwst/insert range               1.00    529.6±0.50µs        ? ?/sec    1.00    528.9±0.24µs        ? ?/sec
ops/array/jwst/remove                     1.00    277.2±0.41µs        ? ?/sec    1.00    275.8±0.23µs        ? ?/sec
ops/array/yrs/insert                      1.04     91.9±2.89µs        ? ?/sec    1.00     88.0±0.53µs        ? ?/sec
ops/array/yrs/insert range                1.00    111.7±0.14µs        ? ?/sec    1.00    111.9±1.30µs        ? ?/sec
ops/array/yrs/remove                      1.00     99.2±0.83µs        ? ?/sec    1.01    100.4±1.01µs        ? ?/sec
ops/text/jwst/insert                      1.00    145.0±3.10µs        ? ?/sec    1.03    149.2±0.97µs        ? ?/sec
ops/text/jwst/remove                      1.00      3.3±0.04µs        ? ?/sec    1.02      3.3±0.04µs        ? ?/sec
ops/text/yrs/insert                       1.01     41.5±0.02µs        ? ?/sec    1.00     41.2±0.04µs        ? ?/sec
ops/text/yrs/remove                       1.01      2.4±0.02µs        ? ?/sec    1.00      2.4±0.00µs        ? ?/sec
update/parse with jwst/basic.bin          1.00     67.5±0.40µs    80.9 MB/sec    1.01     68.0±0.04µs    80.3 MB/sec
update/parse with jwst/database.bin       1.00     54.4±0.03µs    60.9 MB/sec    1.01     55.2±0.04µs    60.0 MB/sec
update/parse with jwst/large.bin          1.00      3.5±0.09ms    64.6 MB/sec    1.00      3.5±0.06ms    64.3 MB/sec
update/parse with jwst/with-subdoc.bin    1.03      6.4±0.07µs   110.2 MB/sec    1.00      6.2±0.02µs   113.1 MB/sec
update/parse with yrs/basic.bin           1.00     44.5±0.05µs   122.8 MB/sec    1.01     45.0±0.28µs   121.3 MB/sec
update/parse with yrs/database.bin        1.00     35.9±0.14µs    92.3 MB/sec    1.03     36.9±0.02µs    89.8 MB/sec
update/parse with yrs/large.bin           1.00      2.3±0.04ms   100.6 MB/sec    1.00      2.3±0.01ms   100.9 MB/sec
update/parse with yrs/with-subdoc.bin     1.00      5.2±0.04µs   135.0 MB/sec    1.27      6.6±0.00µs   106.0 MB/sec

Windows

group                                     master                                 pr
-----                                     ------                                 --
codec/jwst decode var_int (32 bit)        1.00    325.6±1.98µs        ? ?/sec    1.00    325.7±1.84µs        ? ?/sec
codec/jwst decode var_int (64 bit)        1.00    334.1±4.42µs        ? ?/sec    1.00    333.6±0.84µs        ? ?/sec
codec/jwst decode var_uint (32 bit)       1.00    291.3±2.85µs        ? ?/sec    1.00    291.2±2.98µs        ? ?/sec
codec/jwst decode var_uint (64 bit)       1.00    336.7±4.39µs        ? ?/sec    1.00    336.0±5.19µs        ? ?/sec
codec/jwst encode var_int (32 bit)        1.00    397.4±1.97µs        ? ?/sec    1.00    397.3±2.22µs        ? ?/sec
codec/jwst encode var_int (64 bit)        1.02    490.8±2.69µs        ? ?/sec    1.00    482.7±3.19µs        ? ?/sec
codec/jwst encode var_uint (32 bit)       1.00    289.7±7.97µs        ? ?/sec    1.01    291.3±8.92µs        ? ?/sec
codec/jwst encode var_uint (64 bit)       1.00    290.6±8.64µs        ? ?/sec    1.00    292.0±8.18µs        ? ?/sec
codec/lib0 decode var_int (64 bit)        1.00    276.9±1.15µs        ? ?/sec    1.00    276.6±1.45µs        ? ?/sec
codec/lib0 decode var_uint (32 bit)       1.00    259.9±5.81µs        ? ?/sec    1.01    261.7±4.96µs        ? ?/sec
codec/lib0 decode var_uint (64 bit)       1.00    235.6±1.74µs        ? ?/sec    1.00    236.4±3.09µs        ? ?/sec
codec/lib0 encode var_int (64 bit)        1.01   425.3±10.68µs        ? ?/sec    1.00    420.2±1.48µs        ? ?/sec
codec/lib0 encode var_uint (32 bit)       1.00    378.5±2.73µs        ? ?/sec    1.06    401.9±2.96µs        ? ?/sec
codec/lib0 encode var_uint (64 bit)       1.00    377.8±1.52µs        ? ?/sec    1.03    390.1±2.82µs        ? ?/sec
ops/array/jwst/insert                     1.00    426.8±6.06µs        ? ?/sec    1.00    426.5±2.31µs        ? ?/sec
ops/array/jwst/insert range               1.00    544.4±1.67µs        ? ?/sec    1.01    547.7±6.43µs        ? ?/sec
ops/array/jwst/remove                     1.01    286.4±4.99µs        ? ?/sec    1.00    284.9±0.59µs        ? ?/sec
ops/array/yrs/insert                      1.00    100.9±0.38µs        ? ?/sec    1.01    102.0±0.47µs        ? ?/sec
ops/array/yrs/insert range                1.00    141.2±0.75µs        ? ?/sec    1.00    141.5±0.99µs        ? ?/sec
ops/array/yrs/remove                      1.00    140.8±0.60µs        ? ?/sec    1.02    143.2±0.74µs        ? ?/sec
ops/text/jwst/insert                      1.00    168.2±0.84µs        ? ?/sec    1.01    169.7±1.00µs        ? ?/sec
ops/text/jwst/remove                      1.00      4.5±0.02µs        ? ?/sec    1.00      4.5±0.03µs        ? ?/sec
ops/text/yrs/insert                       1.02     44.0±0.11µs        ? ?/sec    1.00     43.2±0.13µs        ? ?/sec
ops/text/yrs/remove                       1.17      4.4±0.07µs        ? ?/sec    1.00      3.8±0.02µs        ? ?/sec
update/parse with jwst/basic.bin          1.03     91.0±0.34µs    60.0 MB/sec    1.00     88.0±0.76µs    62.0 MB/sec
update/parse with jwst/database.bin       1.03     72.0±0.25µs    46.0 MB/sec    1.00     70.1±0.23µs    47.2 MB/sec
update/parse with jwst/large.bin          1.01      4.3±0.11ms    53.1 MB/sec    1.00      4.3±0.08ms    53.7 MB/sec
update/parse with jwst/with-subdoc.bin    1.12     14.5±0.04µs    48.2 MB/sec    1.00     13.0±0.05µs    53.8 MB/sec
update/parse with yrs/basic.bin           1.00     58.7±0.13µs    93.0 MB/sec    1.03     60.4±0.25µs    90.4 MB/sec
update/parse with yrs/database.bin        1.00     46.7±0.10µs    71.0 MB/sec    1.02     47.7±0.20µs    69.5 MB/sec
update/parse with yrs/large.bin           1.00      2.9±0.06ms    78.4 MB/sec    1.00      2.9±0.06ms    78.7 MB/sec
update/parse with yrs/with-subdoc.bin     1.00     10.2±0.06µs    68.9 MB/sec    1.01     10.2±0.07µs    68.5 MB/sec

@darkskygit darkskygit disabled auto-merge August 10, 2023 08:40
@darkskygit darkskygit merged commit 7f70391 into master Aug 10, 2023
@darkskygit darkskygit deleted the darksky/fix_store_assign branch August 10, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants