improve URL joining to prevent malformed cache service URLs #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
thaJeztah
reviewed
Jun 11, 2025
| @@ -545,7 +545,7 @@ func (c *Cache) doWithRetries(ctx context.Context, r *request) (*http.Response, | |||
| } | |||
|
|
|||
| func (c *Cache) url(p string) string { | |||
| return c.URL + "_apis/artifactcache/" + p | |||
| return strings.TrimRight(c.URL, "/") + "/_apis/artifactcache/" + p | |||
There was a problem hiding this comment.
Would it make sense to sanitize / normalize the URL field as part of the constructor, or are there other ways the field can be / is expected to be set?
There was a problem hiding this comment.
I was thinking of parsing the URL with url.Parse and then u.Path, _ = url.JoinPath(u.Path, p) to finally return u.String() but opt for simple fix for this patch.
tonistiigi
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to docker/build-push-action#1382