Skip to content

Setup connection options for SQL Server #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maxime-claudel-totara
Copy link
Contributor

The SQL Server images used in docker-dev are configured with self-issued SSL certificates. These aren't secure so the driver/library will reject connections unless you force it to trust the certificate.
Most developers will use the included SQL Server images, so it makes sense to include that configuration in the default config.php

@markmetcalfe markmetcalfe changed the base branch from master to develop March 30, 2025 21:04
@markmetcalfe markmetcalfe force-pushed the mssql-connection-encryption branch from f039ab9 to bdee391 Compare March 30, 2025 21:04
@markmetcalfe markmetcalfe requested review from markmetcalfe and removed request for markmetcalfe March 30, 2025 21:04
Copy link

@jay-watt jay-watt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working on Windows.

@markmetcalfe markmetcalfe self-requested a review March 31, 2025 00:04
@markmetcalfe markmetcalfe merged commit 50e98be into totara:develop Mar 31, 2025
1 check passed
@markmetcalfe markmetcalfe mentioned this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants