Remove usage of deprecated E_STRICT constant #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scq
commented
Aug 7, 2025
| @ini_set('display_errors', '1'); | ||
| $CFG->debug = (E_ALL | E_STRICT & ~E_DEPRECATED); |
There was a problem hiding this comment.
Operator precedence means this is equivalent to E_ALL | (E_STRICT & ~E_DEPRECATED). E_STRICT & ~E_DEPRECATED equals E_STRICT, so the & ~E_DEPRECATED never did anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
E_STRICTcauses warnings under PHP 8.4, which breaks tdb onmain, as it now defaults to PHP 8.4.