Skip to content

bugfix: path-based header injection #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

bugfix: path-based header injection #851

wants to merge 11 commits into from

Conversation

jranson
Copy link
Member

@jranson jranson commented Jun 5, 2025

PR for #671

@jranson
update struct tags
4b5ee05 
Signed-off-by: James Ranson <[email protected]>
@jranson jranson requested a review from crandles June 5, 2025 16:56
@coveralls
Copy link

coveralls commented Jun 5, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15475705570

Details

  • 3 of 22 (13.64%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on jr/path-configs-fix at 76.5%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/proxy/engines/httpproxy.go 2 3 66.67%
pkg/proxy/headers/headers.go 1 19 5.26%
Totals Coverage Status
Change from base Build 15391613504: 76.5%
Covered Lines: 15271
Relevant Lines: 19962
💛 - Coveralls

@jranson
support host header injection
6882efd 
Signed-off-by: James Ranson <[email protected]>
@jranson jranson changed the title update struct tags bugfix: path-based header injection Jun 5, 2025
jranson added 9 commits June 7, 2025 11:20
@jranson
add/use MatchExactPath constant
df1e3e0 
Signed-off-by: James Ranson <[email protected]>
@jranson
unDRY path key generation
cba4cc7 
Signed-off-by: James Ranson <[email protected]>
@jranson
add consts for prefix/exact match type names
e97b2bb 
Signed-off-by: James Ranson <[email protected]>
@jranson
relocate pprof routing to own pkg
36e3e9f 
Signed-off-by: James Ranson <[email protected]>
@jranson
add pointers pkg
4844515 
Signed-off-by: James Ranson <[email protected]>
@jranson
add clone and pare
29aca4c 
Signed-off-by: James Ranson <[email protected]>
@jranson
Merge branch 'main' into jr/path-configs-fix
62af361 
Signed-off-by: James Ranson <[email protected]>
@jranson
use observability/pprof + add tests
c677173 
Signed-off-by: James Ranson <[email protected]>
@jranson
use idiomatic instantiation of builtin types
46f34a8 
Signed-off-by: James Ranson <[email protected]>
This was referenced Jul 7, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crandles crandles Awaiting requested review from crandles

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jranson @coveralls