ModusTable - maxHeight to support a value which is a number of rows

[axelsean]

Prerequisites

• I have searched for duplicate or closed feature requests
• I have read the Modus style guidelines

Proposal

Currently the maxHeight supports a string, which seems to be interpreted as a height for HTML, so it could be "400px" or "40%"

Supporting a number of rows would remove any dependency on the CSS setting for row sizes.

Motivation and context

rows are cropped when the maxHeight is not an exact multiple of the row height (plus spacing)

This can also be used to size the ModusTable component height correctly - removing the need to set any height explicitly in a surrounding div

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Low

What product/project are you using Modus Components for ?

Trimble Unity Pavement

What is your team/division name ?

AgileAssets

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

[github-actions]

Hello @axelsean! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.