Skip to content

Allow commit.retry.num-retries specified in extra_properties #26316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jinyangli34
Copy link
Contributor

Description

After 470, commit.retry.num-retries became a supported trino property with key max_commit_retry
It no longer allows specifying commit.retry.num-retries in extra_properties and fails on verifyExtraProperties check.

Fixing it by checking if property is specified in extra_properties.

Additional context and related issues

trino:default> create table iceberg.tmp.test_table_commit_num_retry (a varchar, b varchar)
            -> WITH (extra_properties=MAP(ARRAY['commit.retry.num-retries'], ARRAY['10']));
Query 20250731_212004_43651_gsqj6 failed: Illegal keys in extra_properties: [commit.retry.num-retries]
io.trino.spi.TrinoException: Illegal keys in extra_properties: [commit.retry.num-retries]
	at io.trino.plugin.iceberg.IcebergUtil.verifyExtraProperties(IcebergUtil.java:1090)
	at io.trino.plugin.iceberg.IcebergUtil.createTableProperties(IcebergUtil.java:1062)
	at io.trino.plugin.iceberg.IcebergUtil.newCreateTableTransaction(IcebergUtil.java:968)
	at io.trino.plugin.iceberg.IcebergMetadata.beginCreateTable(IcebergMetadata.java:1384)
	at io.trino.plugin.iceberg.IcebergMetadata.createTable(IcebergMetadata.java:1277)

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jul 31, 2025
@github-actions github-actions bot added the iceberg Iceberg connector label Jul 31, 2025
@jinyangli34 jinyangli34 requested a review from ebyhr July 31, 2025 21:22
@ebyhr
Copy link
Member

ebyhr commented Jul 31, 2025

I don't think we want to allow setting commit.retry.num-retries via extra_properties anymore.

@jinyangli34
Copy link
Contributor Author

I don't think we want to allow setting commit.retry.num-retries via extra_properties anymore.

that causes issue when upgrading the cluster. user cannot have a query working for both older/newer versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

2 participants