Added support for the timestamp type for statistics in trino-hive connector #26338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-kutuzov
changed the title
anton-kutuzov
force-pushed
the
add_suporting_tymestamp_in_statistics
branch
from
d916970 to
f8e8a57
Compare
ebyhr
reviewed
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for the
timestamptype in statistics calculation.To maintain compatibility with
Hivestatistics, the computedminandmaxvalues are truncated to seconds during write by dividing byMICROSECONDS_PER_SECOND, usingfloorforminandceilformaxto avoid losing millisecond precision. When reading, values are converted back to Trino format by multiplying byMICROSECONDS_PER_SECOND.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: