Skip to content

Trino Case Sensitivity support : Introduce NameCanonicalizer to the metadata #26339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrlso
Copy link

@chrlso chrlso commented Aug 4, 2025

Description

Related to issue: #17

Supersedes: pr #7837 and pr #2350

Adding base connector support for Name canonicalization to enable case sensitivity support at the connector level. This enabled connectors to decide what is the conical form for a database/schema or table identifier when loading table metadata.

Connectors can use this method to determine how to handle delimited and non delimited identifiers within a given query.

Currently Trino table metadata handles table and schema names in a case insensitive manner. All table names are downcased meaning the engine cannot distinguish "name" from "Name"

This change is a prerequisite to enabling support for case sensitive table and schema names within supported connectors.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Copy link

cla-bot bot commented Aug 4, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added iceberg Iceberg connector hive Hive connector kafka Kafka connector pinot Pinot connector prometheus Prometheus connector labels Aug 4, 2025
@chrlso chrlso marked this pull request as ready for review August 4, 2025 20:27
@ebyhr
Copy link
Member

ebyhr commented Aug 4, 2025

cc: @martint @kasiafi @Praveen2112

Copy link

cla-bot bot commented Aug 5, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@chrlso chrlso force-pushed the case-sensitivity branch from c277531 to 6f2c1df Compare August 5, 2025 17:08
Copy link

cla-bot bot commented Aug 5, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@chrlso chrlso force-pushed the case-sensitivity branch from 6f2c1df to b21b03f Compare August 7, 2025 14:49
Copy link

cla-bot bot commented Aug 7, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Aug 11, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Aug 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@chenjian2664
Copy link
Contributor

@chrlso Just check, have you sent the signed cla?

@chrlso
Copy link
Author

chrlso commented Aug 14, 2025

@chrlso Just check, have you sent the signed cla?

Yes, I submitted last week, waiting on that to be approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hive Hive connector iceberg Iceberg connector kafka Kafka connector pinot Pinot connector prometheus Prometheus connector
Development

Successfully merging this pull request may close these issues.

3 participants