-
Notifications
You must be signed in to change notification settings - Fork 33
Add gpu_driven_amd with AMD GPU support #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@CalebZ9909 Looks great. Can you put your code also in the |
Nice. I think my past wording was confusing. You should also do |
Yes, I am done on my side. Ziming and you can check the code now. I am working on testing the code and will update next version soon. |
Thanks @CalebZ9909 , ideally we can define a flag (e.g. HIP_PLATFORM_AMD in rdma folder) so that we can toggle whether to run on AMD platform from the makefile. It should not overwrite all existing cuda commands with hip but keeping the option to toggle between the two Maybe we can define some function name to either refer to the cuda version or the hip version depending on the macro. e.g. (either hipMemcpyPeerAsync or cudaMemcpyPeerAsync). |
I have some macro defination at https://github.com/uccl-project/uccl/blob/main/include/util/gpu_rt.h |
Sounds good! Yes, I can set up a flag and keep all CUDA-related files along with AMD files, which can be chosen to be executed by the flag in the makefile. |
I guess a better way is to use the unified name like |
Sure, I will look into this! |
Add AMD HIP for gpu_driven on AMD GPUs