Skip to content

feat(examples): Add Playwright (Chromium) on Node example #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

razvand
Copy link
Contributor

@razvand razvand commented Sep 10, 2024

Add a simple screenshot example working with Playwright on Node.

TODOs:

  • Minimize Docker container (in Dockerfile).
  • Have image work on Unikraft Cloud.
  • Update the image to provide a service for getting a image file (the screenshot).
  • Add README.md.
  • Add workflow and badge.

@razvand razvand added the enhancement New feature or request label Sep 10, 2024
@razvand razvand requested a review from nderjung September 10, 2024 11:57
@razvand razvand force-pushed the razvand/examples/node-playwright branch 2 times, most recently from b8eec7c to e77eb60 Compare September 10, 2024 21:00
@razvand razvand marked this pull request as ready for review September 10, 2024 21:01
@razvand razvand force-pushed the razvand/examples/node-playwright branch from e77eb60 to 8fa201a Compare September 11, 2024 05:02
@razvand razvand requested a review from nderjung September 11, 2024 05:02
@razvand razvand force-pushed the razvand/examples/node-playwright branch from 8fa201a to d8a123e Compare September 11, 2024 13:43
@razvand razvand requested review from craciunoiuc and removed request for nderjung January 27, 2025 07:50
@razvand razvand assigned craciunoiuc and unassigned nderjung Jan 27, 2025
@razvand razvand requested review from nderjung and removed request for nderjung January 27, 2025 07:51
@razvand razvand force-pushed the razvand/examples/node-playwright branch from d8a123e to bd91f89 Compare January 27, 2025 09:07
@razvand razvand changed the title feat(examples): Add Playwright on Node example feat(examples): Add Playwright (Chromium) on Node example Jan 27, 2025
Copy link
Contributor

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu [email protected]
Approved-by: Cezar Craciunoiu [email protected]

Introduce a Playwright (Chromium) example to be deployed on Unikraft
Cloud with Node. It uses the `base-compat:latest` image.

Add:

* `Kraftfile`: build / run rules
* `Dockerfile`: placeholder to extract the filesystem
* `package.json`: NPM configuration file
* `server.js`: implementation of Node server
* `wrapper.sh`: helper script to start the Node server
* `README.md`: document how to use
* `.dockerignore` / `.gitignore`: ignore generated files
* workflow files in `../.github/workflows/`

Update top-level `README.md` to feature the example.

Signed-off-by: Razvan Deaconescu <[email protected]>
@razvand razvand force-pushed the razvand/examples/node-playwright branch from bd91f89 to edea098 Compare January 30, 2025 07:37
Copy link
Contributor

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu [email protected]
Approved-by: Cezar Craciunoiu [email protected]

@craciunoiuc craciunoiuc merged commit ac3209c into unikraft-cloud:main Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants