Studio: calibrate Linux chat typography against macOS#7337
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
oobabooga
changed the title
for more information, see https://pre-commit.ci
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f456f49d22
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
for more information, see https://pre-commit.ci
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
PR #7308 lowered inherited regular chat text on Linux from 410 to 350. That improved dark-mode darkness, but made light-mode text too light and made dark-mode lines wrap earlier than the macOS reference.
This follow-up calibrates both themes for the default Inter path on desktop Linux:
0.023emtracking to reduce width and wrap drift without changing its measured text coverage.Native rendering comparison
Difference in background-normalized sRGB foreground coverage relative to native macOS at weight 410:
Positive values are heavier than macOS by this metric; negative values are lighter.
The dark-mode tracking correction improves layout without materially changing text coverage:
Visual check
Measurement methodology
Captures used Chrome for Testing 149.0.7827.55, the production Inter WOFF2, device pixel ratio 1, native FreeType rendering on Linux, and native CoreText rendering on macOS 14.5 on Apple silicon. Three repeated captures of each state were bit-identical.
A 5-unit light-mode weight sweep found 390 closest under normalized sRGB. It was also evaluated using CIE L* and linear luminance, so the choice does not depend on a single perceptual transform.
Scope and validation
The selector targets only desktop-Linux assistant and user message roots on the default font path. macOS, Android, custom chat or UI fonts, and the font-smoothing opt-out retain the existing typography. Explicit text weights are retained; the dark tracking adjustment is inherited within the affected message roots.
python -m py_compile tests/studio/playwright_chat_ui.pyruff check tests/studio/playwright_chat_ui.pynpm run build