Studio voice-tab: use text-ui-* tokens instead of raw px text sizes#7378
Open
LeoBorcherding wants to merge 1 commit into
Open
Studio voice-tab: use text-ui-* tokens instead of raw px text sizes#7378LeoBorcherding wants to merge 1 commit into
LeoBorcherding wants to merge 1 commit into
Conversation
The STT model list used text-[9px] and text-[10px], which ignore the UI font-size preference and fail the test_no_raw_pixel_text_utilities contract. Swap them for the scale-aware text-ui-9 / text-ui-10 tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The STT dictation model list in
voice-tab.tsxusestext-[9px]andtext-[10px], which ignore the UI font-size preference and fail thetest_no_raw_pixel_text_utilitiescontract test (currently red on Repo tests (CPU)).Swap them for the scale-aware
text-ui-9/text-ui-10tokens already defined inindex.css. No visual change at the default scale; the sizes now track the user's UI font-size setting like every other text utility.