♻️ Auto-compute certain need fields #1496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of need fields are actually data that is based on other data:
is_need
/is_part
are based on whether the item is aNeedItem
orNeedPartItem
instanceis_modified
is based on ifmodifications > 0
id_parent
/id_complete
are based on theid
(and partid
ifNeedPartItem
)section_name
is the first item insections
parent_need
is the first item in theparent_needs
linksconstraints
is the keys ofconstraints_results
constraints_passed
is derived fromconstraints_results
These are mainly there for user convenience when writing filters, but are not necessary to specify independently, and could lead to inconcistencies in the data.
Therefore, these fields are now auto-computed when initialiasing/modifying the need, rather than being allowed to be specified / modified independantly.