This repository was archived by the owner on Apr 7, 2022. It is now read-only.
fix unnecessary body copying #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tanner0101, you just merged a pull request, have a coin! You now have 1136 coins. |
|
Is it possible to write a test case to make sure this doesn't happen again? Maybe just a performance test would do. |
|
@calebkleveter yeah I think a performance test for a large file upload would do the trick. I'll open an issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that causes HTTP request body byte buffer to reallocate unnecessarily. During large file uploads, this issue quickly consumes the CPU.
The reason for the copy is that
HTTPServerStatecontinues to hold a reference to the HTTP requestByteBufferwhen the new chunk is written. Since the buffer is not uniquely referenced, the write triggers a copy.To fix this, the request body buffer is moved outside of the state enum to a member var. This ensures the ByteBuffer is uniquely referenced during body collection.