fix: disk resizing and unexpected disk deletion #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanael-h
approved these changes
Jun 17, 2025
This was referenced Jul 31, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #328 and #178 and #214
When attempting to expand a disk, the process actually deleted the disk and created a new one without shutting down the VM first.
This can result in data loss and the VM freezing unexpectedly.
To avoid this, the VM is now shut down before the attached disk is resized, and other changes should not delete the disk.
Disk migration from one storage repository to another is not supported by the provider and should not involve deleting and recreating the disk.
Related to vatesfr/xenorchestra-go-sdk#26