Skip to content

Bump catch2 to 3.9.1 #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Bump catch2 to 3.9.1 #899

merged 1 commit into from
Aug 15, 2025

Conversation

elazarg
Copy link
Collaborator

@elazarg elazarg commented Aug 14, 2025

Summary by CodeRabbit

  • Tests
    • Updated the unit testing framework to the latest patch release to align with upstream fixes and improve test stability.
  • Chores
    • Performed routine maintenance on test-related dependencies to keep the build and verification pipeline current.
    • No changes to user-facing features or behavior; application functionality remains unchanged.

Signed-off-by: Elazar Gershuni <[email protected]>
@vbpf vbpf deleted a comment from coderabbitai bot Aug 14, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 69fdeab and d9a64d5.

📒 Files selected for processing (1)
  • CMakeLists.txt (1 hunks)
🔇 Additional comments (1)
CMakeLists.txt (1)

35-35: Scoped dependency bump looks correct

Catch2 tag updated to v3.9.1 only within the tests block; target linkage to Catch2::Catch2WithMain remains valid in v3.x. No build graph or consumer targets are impacted.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16976415020

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.137%

Totals Coverage Status
Change from base Build 16852663283: 0.0%
Covered Lines: 8566
Relevant Lines: 9719

💛 - Coveralls

@vbpf vbpf deleted a comment from coderabbitai bot Aug 15, 2025
@elazarg elazarg merged commit c2a3a11 into main Aug 15, 2025
16 checks passed
@elazarg elazarg deleted the bump-catch2-to-3.9.1 branch August 15, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants