Skip to content

feat(core,react,docs): Add async deck picking methods #9733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Aug 2, 2025

Closes #

Background

  • This exposes the new async deck picker methods in the public API

Change List

  • Adds new core Deck components async picking APIs
  • Adds new React Deck components async picking APIs
  • Adds docs

TODO

  • Use pickAsync in deck event picking (hover/click) in Deck._pickAndCallback()
  • Update usage in examples (layer browser)
  • Add tests for the new async versions
  • WebGPU - bump luma and implement async WebGPU picking in DeckPicker class
  • WebGL - async picking performance could be improved somewhat by adding a WebGL2 fenceSync to the GPU command queue and polling for it to complete before starting the sync readback.
  • Determine how to correctly implement pickMultipleObjectsAsync()
    • Does it need to save state between picking operations? (since no longer sync, deck props could change...)
    • Should we not offer the pickMultipleObjectsAsync async version for now?

Base automatically changed from ib/async-deck-picker to master August 3, 2025 13:17
@ibgreen ibgreen force-pushed the ib/async-deck-picking branch from 3f393d5 to b48ea96 Compare August 3, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants