Incorrect output for V full version with VCURRENTHASH not defined

[lcheylus]

Describe the bug

I'm packaging V 0.4.10 for OpenBSD (lang/v port in OpenBSD ports tree).

V compiler and tools are built from packaged sources (outside of Git sources tree). In this case, VCURRENTHASH is not defined.

V full version output is incorrect in this case: no VCURRENTHASH and extra dot.

$ v -v version
V 0.4.10 9b1937a87166e3327497f332bf9584ff90592617.

Reproduction Steps

Build OpenBSD lang/v port from 0.4.10 sources => see https://github.com/openbsd/ports/tree/master/lang/v

After build and install, run V binary to get full version: v -v version

Expected Behavior

Output for V full version when VCURRENTHASH is not defined

$ v version
V 0.4.10

$ v -v version
V 0.4.10 9b1937a87166e3327497f332bf9584ff90592617

Current Behavior

See above

Possible Solution

Fix in vlib/v/util/version/version.v for the case when VCURRENTHASH is not defined.

I have a patch to fix this issue => I will create a PR ASAP.

Additional Information/Context

No response

V version

V 0.4.10 11e25bc

Environment details (OS name and version, etc.)

V full version	V 0.4.10 11e25bc.11e25bc
OS	openbsd, 7.7, GENERIC.MP#624
Processor	4 cpus, 64bit, little endian
Memory	1.77GB/3.98GB
V executable	/home/fox/dev/vlang.git/v
V last modified time	2025-04-18 13:52:42
V home dir	OK, value: /home/fox/dev/vlang.git
VMODULES	OK, value: /home/fox/.vmodules
VTMP	OK, value: /tmp/v_1000
Current working dir	OK, value: /home/fox/dev/vlang.git
Git version	git version 2.49.0
V git status	weekly.2025.16-14-g11e25bc9-dirty
.git/config present	true
cc version	OpenBSD clang version 16.0.6
gcc version	egcc (GCC) 11.2.0
clang version	OpenBSD clang version 16.0.6
tcc version	tcc version 0.9.28rc 2024-09-14 HEAD@b8b6a5fd (x86_64 OpenBSD)
tcc git status	thirdparty-openbsd-amd64 8205cc59
emcc version	N/A
glibc version	N/A

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

[huly-for-github]

Connected to Huly®: V_0.6-22641

[JalonSolov]

Not sure what's been changed, but that's not the normal output for v version. This is:

$ v version
V 0.4.10 11e25bc
$ v -v version
V 0.4.10 f581bb7.11e25bc
$

[lcheylus]

@JalonSolov

No, with the last version of Git sources, after rebuild on Linux Debian/amd64, v version output is:

$ ./v version
V 0.4.10 11e25bc
$ ./v -v version
V 0.4.10 11e25bc9ea30ffde14bcd51d79ced465e3dcb4e2.11e25bc

With verbose output, full hash for C.V_COMMIT_HASH is displayed (no short output): return from vhash() function in vlib/v/util/version/version.c.v (C.V_COMMIT_HASH defined in vc/v.c).

$ grep -n V_COMMIT_HASH vc/v.c
1:#define V_COMMIT_HASH "11e25bc9ea30ffde14bcd51d79ced465e3dcb4e2"

[lcheylus]

@felipensp This issue is not specific to OpenBSD.

I have the same issue if I build V 0.4.10 on Linux from sources (outside of Git sources tree). For example, Makefile to build V 0.4.10 Alpine Linux package from sources => https://gitlab.alpinelinux.org/alpine/aports/-/blob/20715540fff68ba943d273284c4248b4bba82d09/testing/vlang/APKBUILD

$ lsb_release -d -s
Debian GNU/Linux trixie/sid

# Download packaged sources for V 0.4.10 and vc commit 66ea39be2275ac723225b9ca99d51ec1212c640d
$ wget https://github.com/vlang/v/archive/refs/tags/0.4.10.tar.gz -O v-0.4.10.tar.gz
$ wget https://github.com/vlang/vc/archive/66ea39be2275ac723225b9ca99d51ec1212c640d.tar.gz -O vc-66ea39be2275ac723225b9ca99d51ec1212c640d.tar.gz

# Extract sources for V 0.4.10
$ tar xzvf v-0.4.10.tar.gz
$ tar xzvf vc-66ea39be2275ac723225b9ca99d51ec1212c640d.tar.gz

$ cd v-0.4.10
$ mv ../vc-66ea39be2275ac723225b9ca99d51ec1212c640d ./vc

# Build with local sources
$ make local=1 prod=1
Using local vc
Using local tcc
The executable './thirdparty/tcc/tcc.exe' does not work.
cc  -std=gnu99 -w -o v1 ./vc/v.c -lm -lpthread  || cmd/tools/cc_compilation_failed_non_windows.sh
./v1 -no-parallel -o v2 -prod cmd/v
./v2 -nocache -o ./v -prod cmd/v
rm -rf v1 v2

# Output for V version
$ ./v version
V 0.4.10
$ ./v -v version
V 0.4.10 9b1937a87166e3327497f332bf9584ff90592617.

Same issue with v -v version output when VCURRENTHASH is not defined.

[JalonSolov]

@JalonSolov

No, with the last version of Git sources, after rebuild on Linux Debian/amd64, v version output is:

$ ./v version
V 0.4.10 11e25bc
$ ./v -v version
V 0.4.10 11e25bc9ea30ffde14bcd51d79ced465e3dcb4e2.11e25bc

That is what I am saying is incorrect. The hash before the . in the verbose output is supposed to be the version you have before doing v up, and it should be a short hash.

The hash after the . should be the one you just got with the update.

So there are 2 things wrong with that output - it is showing a long hash instead of a short one for the first value, and it is showing the current hash for both, instead of <previous>.<current> as it should.