toml: fix crlf escape check #24329
Merged
toml: fix crlf escape check #24329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: V_0.6-22705 |
larpon
reviewed
Apr 26, 2025
Comment on lines
+4
to
+8
| toml_txt := 'str1 = """tcc \\\r\nabc \\\r\n123"""' | ||
| toml_doc := toml.parse_text(toml_txt) or { panic(err) } | ||
|
|
||
| value := toml_doc.value('str1').string() | ||
| assert value == 'tcc abc 123' |
There was a problem hiding this comment.
Should this not be a string printed like this?:
assert value == 'tcc \
abc \
123'According to https://toml.io/en/v1.0.0#string it should be parsed as a multi-line basic string.
And a basic string should show a literal \ if you escape it with \. So """tcc \\\r\nabc \\\r\n123""" should become: tcc \\r\nabc \\r\n123 when "rendered"?
There was a problem hiding this comment.
I am honestly a little rusty in the spec since I implemented the toml module and I am uncertain if \r\n should result in just \n on unix and \r\n on windows 🤔
There was a problem hiding this comment.
When creating toml file under Windows, if has no this patch , it is simply can't write multiline string.
like this :
str1 = """ a \
b \
c
"""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24328