Skip to content

x.crypto.chacha20: add a check counter overflow to set_counter #24365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

blackshirt
Copy link
Contributor

@blackshirt blackshirt commented Apr 30, 2025

This small PR contains two small fix,

  1. The first part was adding check into .set_counter routine, especially in standard variant where its only allowing 32bit counter values.
  2. The second fixs the warning when run the test of chacha_64bitctr_test with -cstrict options, would lead into error: integer constant is so large that it is unsigned [-Werror] because counter was defined as int before changes.

Thanks

Copy link

Connected to Huly®: V_0.6-22741

@spytheman spytheman merged commit f8c35b4 into vlang:master Apr 30, 2025
64 checks passed
@blackshirt blackshirt deleted the fix-chacha20-set-counter branch May 1, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants