Skip to content

math.big: reminder must respect the sign of dividend in % operator, a… #24489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

tankf33der
Copy link
Contributor

@tankf33der tankf33der commented May 15, 2025

% operator of math.big does not respect sign of dividend.

Just copy-paste from / operator for sign management.
Now it can pass new test and 1M loop against libgmp.

Copy link

Connected to Huly®: V_0.6-22858

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 029564b into vlang:master May 15, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants