-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix: Dynamic route split regex #14108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0624fc4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #14108 will not alter performanceComparing Summary
|
@ematipico given that tests pass, do you think it's safe to merge? |
Not sure why you ask me 😅 @JusticeMatthew, what's the "super-linear backtracking"? Why didn't we add a for it? |
It was the error that showed up with the previous regex Based on my research allegedly it can cause increased time complexity and in some rare cases infinite retrys |
Changes
Testing
I ran all the routing unit tests, and they passed
Docs
No docs update required