fix(integrations): Improper code sanitization #14201
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the problem, we need to ensure that any potentially dangerous characters in the stringified headings are properly escaped before embedding them in the generated JavaScript code. The best way to do this is to escape characters such as
<
,>
,/
,\
, and certain Unicode line/paragraph separators, as well as control characters, in the output ofJSON.stringify(headings)
. This can be achieved by defining anescapeUnsafeChars
function (as in the example) and applying it to the stringified headings before constructing the export statement. The change should be made inpackages/integrations/mdx/src/rehype-collect-headings.ts
, specifically on line 8, and the function should be defined in the same file or imported if already available.