Skip to content

[Glass] Update default field to 2025 for Field2D #7820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

rmheuer
Copy link
Contributor

@rmheuer rmheuer commented Feb 24, 2025

The default size is from the field JSON file in fieldImages, converted from feet to meters.

@rmheuer rmheuer requested a review from a team as a code owner February 24, 2025 18:59
@github-actions github-actions bot added the component: glass Glass app and backend label Feb 24, 2025
@chauser
Copy link
Contributor

chauser commented Feb 24, 2025

I think SimGUI may also display the 2024 field by default -- at least it seems to for me. Does this fix SimGUI as well? Or is there another place that needs to be changed, too?

@rmheuer
Copy link
Contributor Author

rmheuer commented Feb 24, 2025

I think the SimGUI uses glass for the common components so it should also fix SimGUI.

@PeterJohnson PeterJohnson merged commit b0e588f into wpilibsuite:main Feb 26, 2025
45 checks passed
@rmheuer rmheuer deleted the update-default-field branch March 1, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: glass Glass app and backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants