Improvement: Do not continue re-connect after quit/shutdown/hibernate/suspend #1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
changed the title
Avoid code duplication
Calling disconnectFromActiveServer resets the server settings which is equal to not having server selected. In case the server list is shown, the active server must be deselected.
wutschel
force-pushed
the
fix_server_status_shutdown
branch
from
0afbce2 to
0ceb471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #633.
Stop re-connection attempts after user selected Quit Application, Shutdown System, Hibernate System or Suspend System from the power menu and Kodi reported success. To stay consistent with the status reflected in the UI, the current selected server is unselected. After Remote App relaunch there is no server connection attempted to be connected again. The user needs to select the desired server again.
Summary for release notes
Improvement: Do not continue re-connect after quit/shutdown/hibernate/suspend