Skip to content

feat: extract magic number & ref type #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Conversation

darkskygit
Copy link
Collaborator

No description provided.

@darkskygit darkskygit requested a review from forehalo August 30, 2023 10:31
@darkskygit darkskygit temporarily deployed to development August 30, 2023 10:31 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +55.50% 🎉

Comparison is base (381cc95) 22.17% compared to head (49ecb01) 77.68%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #16       +/-   ##
===========================================
+ Coverage   22.17%   77.68%   +55.50%     
===========================================
  Files           1       42       +41     
  Lines         257     6619     +6362     
===========================================
+ Hits           57     5142     +5085     
- Misses        200     1477     +1277     
Flag Coverage Δ
node-binding-test 22.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
y-octo/src/doc/common/state.rs 80.48% <0.00%> (ø)
y-octo/src/lib.rs 100.00% <ø> (ø)
y-octo/src/doc/codec/delete_set.rs 92.30% <100.00%> (ø)
y-octo/src/doc/codec/update.rs 87.08% <100.00%> (ø)
y-octo/src/doc/common/somr.rs 87.61% <100.00%> (ø)
y-octo/src/doc/publisher.rs 54.54% <100.00%> (ø)

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkskygit darkskygit temporarily deployed to development August 30, 2023 10:47 — with GitHub Actions Inactive
@darkskygit darkskygit merged commit f544369 into main Aug 30, 2023
@darkskygit darkskygit deleted the darksky/extract-magic-number branch August 30, 2023 10:52
@github-actions
Copy link

Benchmark for Linux

Click to view benchmark
Test Base PR %
codec/jwst decode var_int (32 bit) 333.5±1.21µs 333.8±1.73µs +0.09%
codec/jwst decode var_uint (32 bit) 285.9±0.68µs 286.0±0.85µs +0.03%
codec/jwst decode var_uint (64 bit) 308.2±0.16µs 308.2±0.09µs -0.00%
codec/jwst encode var_int (32 bit) 424.0±2.01µs 422.6±1.97µs -0.33%
codec/jwst encode var_uint (32 bit) 375.3±0.16µs 375.3±0.19µs -0.00%
codec/jwst encode var_uint (64 bit) 375.4±1.32µs 375.3±0.21µs -0.03%
codec/lib0 decode var_int (64 bit) 268.6±0.45µs 268.7±2.20µs +0.04%
codec/lib0 decode var_uint (32 bit) 257.3±3.92µs 262.8±5.76µs +2.14%
codec/lib0 decode var_uint (64 bit) 264.7±3.04µs 264.8±3.80µs +0.04%
codec/lib0 encode var_int (64 bit) 418.9±6.18µs 424.5±7.39µs +1.34%
codec/lib0 encode var_uint (32 bit) 383.7±6.90µs 381.2±1.23µs -0.65%
codec/lib0 encode var_uint (64 bit) 376.3±0.58µs 377.6±1.15µs +0.35%
ops/array/jwst/insert 377.3±4.38µs 377.8±2.36µs +0.13%
ops/array/jwst/insert range 508.6±0.20µs 511.9±0.28µs +0.65%
ops/array/jwst/remove 262.8±0.35µs 263.1±0.08µs +0.11%
ops/array/yrs/insert 83.1±1.12µs 83.2±0.12µs +0.12%
ops/array/yrs/insert range 105.4±0.19µs 107.2±1.35µs +1.71%
ops/array/yrs/remove 91.2±0.35µs 93.0±0.19µs +1.97%
ops/text/jwst/insert 142.1±0.96µs 142.0±1.09µs -0.07%
ops/text/jwst/remove 3.2±0.00µs 3.3±0.00µs +3.12%
ops/text/yrs/insert 36.1±0.06µs 36.0±0.04µs -0.28%
ops/text/yrs/remove 2.4±0.06µs 2.3±0.03µs -4.17%
update/parse with jwst/basic.bin 65.7±0.05µs 65.9±0.10µs +0.30%
update/parse with jwst/database.bin 53.4±0.02µs 53.5±0.02µs +0.19%
update/parse with jwst/large.bin 4.9±0.01ms 4.9±0.01ms -0.00%
update/parse with jwst/with-subdoc.bin 6.3±0.02µs 6.1±0.01µs -3.17%
update/parse with yrs/basic.bin 41.6±0.08µs 43.1±0.02µs +3.61%
update/parse with yrs/database.bin 33.4±0.05µs 34.9±0.02µs +4.49%
update/parse with yrs/large.bin 3.1±0.00ms 3.1±0.00ms -0.00%
update/parse with yrs/with-subdoc.bin 5.6±0.01µs 5.3±0.00µs -5.36%

Benchmark for Windows

Click to view benchmark
Test Base PR %
codec/jwst decode var_int (32 bit) 352.3±2.74µs 352.0±2.73µs -0.09%
codec/jwst decode var_uint (32 bit) 286.6±1.54µs 286.4±1.17µs -0.07%
codec/jwst decode var_uint (64 bit) 294.9±1.31µs 294.8±1.42µs -0.03%
codec/jwst encode var_int (32 bit) 395.4±1.64µs 395.3±2.05µs -0.03%
codec/jwst encode var_uint (32 bit) 292.6±6.44µs 294.9±12.31µs +0.79%
codec/jwst encode var_uint (64 bit) 289.7±5.98µs 291.9±7.33µs +0.76%
codec/lib0 decode var_int (64 bit) 277.7±5.23µs 276.9±0.89µs -0.29%
codec/lib0 decode var_uint (32 bit) 259.7±6.03µs 262.7±6.20µs +1.16%
codec/lib0 decode var_uint (64 bit) 238.4±3.38µs 237.9±2.91µs -0.21%
codec/lib0 encode var_int (64 bit) 453.0±8.29µs 448.6±6.36µs -0.97%
codec/lib0 encode var_uint (32 bit) 363.8±1.96µs 362.1±2.34µs -0.47%
codec/lib0 encode var_uint (64 bit) 394.7±13.67µs 392.0±3.80µs -0.68%
ops/array/jwst/insert 424.5±12.16µs 421.1±2.71µs -0.80%
ops/array/jwst/insert range 544.6±31.29µs 541.1±2.45µs -0.64%
ops/array/jwst/remove 281.0±0.90µs 280.2±0.78µs -0.28%
ops/array/yrs/insert 102.0±2.11µs 100.7±0.37µs -1.27%
ops/array/yrs/insert range 139.9±0.62µs 140.4±1.12µs +0.36%
ops/array/yrs/remove 146.6±1.69µs 146.2±0.95µs -0.27%
ops/text/jwst/insert 171.5±0.99µs 172.1±0.93µs +0.35%
ops/text/jwst/remove 3.9±0.01µs 4.5±0.01µs +15.38%
ops/text/yrs/insert 42.3±0.30µs 42.9±0.19µs +1.42%
ops/text/yrs/remove 3.6±0.01µs 4.2±0.02µs +16.67%
update/parse with jwst/basic.bin 89.0±0.49µs 87.7±0.56µs -1.46%
update/parse with jwst/database.bin 70.6±0.38µs 68.1±0.25µs -3.54%
update/parse with jwst/large.bin 4.2±0.09ms 4.2±0.19ms -0.00%
update/parse with jwst/with-subdoc.bin 14.1±0.06µs 12.7±0.03µs -9.93%
update/parse with yrs/basic.bin 58.8±0.23µs 58.9±0.28µs +0.17%
update/parse with yrs/database.bin 46.8±0.84µs 47.4±0.19µs +1.28%
update/parse with yrs/large.bin 3.0±0.09ms 2.9±0.07ms -3.33%
update/parse with yrs/with-subdoc.bin 10.0±0.28µs 10.3±0.05µs +3.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants