Add support for named folder icons #36351
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a "named_directory_icons" field to the icon theme that can be used to specify a collection of icons for collapsed and expanded folders based on the folder name the value specified is the key into "file_icons" for the icon to use
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
|
I will try and resolve the conflicts shortly :) just having a bit of trouble compiling the latest version of Zed on Windows was having a bit of cargo issues with one of the recent changes so have been working on a older copy. I think its resolved now after reinstalling the toolchain though just waiting for the build now |
Add back a change that was removed when merging to get past a conflict that changed some code significantly
|
All up to date now :) |
|
are we going to have this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "named_directory_icons" field to the icon theme that can be used to specify a collection of icons for collapsed and expanded folders based on the folder name the value specified is the key into "file_icons" for the icon to use.
Allows associating the name of a folder to a specific folder icon for folder names that have some sort of meaning. Makes it easier in large code bases to differentiate folders from eachother at a glance
I believe this needs a bump in the icon_themes schema
Closes #20295
Also referenced #23987 (comment)
Release Notes:
Example using https://github.com/jacobtread/zed-vscode-icons/ which I've ported over from a VSCode theme,