feat: Implement Indexed builder class#3
Closed
zonca wants to merge 10 commits into
Closed
Conversation
ManasviGoyal
requested changes
Dec 5, 2023
Collaborator
|
@zonca The PR name should have a |
zonca
changed the title
zonca
commented
Dec 5, 2023
Forked repositories normally do not have secrets correctly configured See https://github.com/orgs/community/discussions/26409#discussioncomment-3251822
ManasviGoyal
requested changes
Dec 6, 2023
ManasviGoyal
approved these changes
Dec 7, 2023
Collaborator
|
@zonca please make a PR to awkward if you are done with it. Thanks! |
jpivarski
approved these changes
Dec 8, 2023
jpivarski
left a comment
jpivarski
left a comment
There was a problem hiding this comment.
@ManasviGoyal has already approved this, and we only require one approval, but I looked it over also and approve it as well.
I'll merge it. Thanks, @zonca!
jpivarski
approved these changes
Dec 8, 2023
jpivarski
left a comment
jpivarski
left a comment
There was a problem hiding this comment.
For some reason, that didn't set the "approve" checkmark. This should do it.
|
Nope. Oh well! |
|
Wait a minute, why can't I merge this? Oh! It's a PR into zonca/awkward. I see scikit-hep#2883 and will go there now. |
Owner
Author
|
I'm closing this PR, let's refer to the one in the official repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I compare the implementation to a branch where I have just copy-pasted
IndexedOptionto more easily compare the differences between the 2 implementations.