Fix #179: added copy_simp and supplementarity_simp to full_reduce #332
+58
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdwetering
reviewed
Aug 15, 2025
| g.add_edge((v1, v3)) | ||
| g1 = g.copy() | ||
| to_gh(g1) | ||
| copy_simp(g1) |
There was a problem hiding this comment.
You should probably also assert that copy_simp actually simplified the graph, and that this is not a 'noop'.
asserted that copy_simp simplified the graph correctly
lara-madison
changed the title
jvdwetering
reviewed
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified full_reduce to apply both copy and supplementarity rules when possible, and added test for the copy_simp functionality