-
Notifications
You must be signed in to change notification settings - Fork 1
Solving Dart Warnings #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced Groovy Gradle files with Kotlin DSL (.kts) equivalents. - Updated Gradle wrapper to version 8.12. - Updated Android Gradle Plugin and Kotlin versions. - Modified `AndroidManifest.xml` files: - Removed `package` attribute from root manifest. - Added `taskAffinity=""` to `MainActivity`. - Added `<queries>` for `ACTION_PROCESS_TEXT`. - Updated `.gitignore` to include `.cxx/`. - Increased Gradle JVM arguments in `gradle.properties`. - Updated various dependency versions in `pubspec.lock`. - Added empty test files for iOS and macOS.
- Enable stricter type checks (`strict-casts`, `strict-raw-types`) in `analysis_options.yaml`. - Exclude `build/**` directory from linting. - Point MegaLinter to the correct Dart analyzer configuration file. - Removed commented-out informational section in `analysis_options.yaml`.
This commit introduces a new `analysis_options.yaml` file for Flutter projects. This file defines a set of linter rules to enforce coding standards and best practices. The specific rules added are based on the recommended set from `package:flutter_lints`, aiming to improve code quality, readability, and maintainability. The Mega-Linter configuration has also been updated to remove the explicit reference to a Dart analyzer config file, as the standard `analysis_options.yaml` will now be used by default.
Replaced double quotes with single quotes for string literals across the codebase for consistency. This change primarily affects property lookups in `fromJson` methods and static key definitions in builder classes.
The Dartanalyzer will now run `flutter pub get` in the `flutter/craftd_widget` and `flutter/sample` directories before analysis. This ensures that dependencies are fetched, which is necessary for the analyzer to function correctly.
This commit updates the MegaLinter configuration by: - Removing pre-commands for Dart analyzer, as they are no longer needed. - Ensuring JavaScript Standard errors are disabled.
gabrielbmoro
commented
Jul 27, 2025
The `DART_DARTANALYZER_CLI_EXECUTABLE` configuration for `flutter` has been replaced with `DART_DARTANALYZER_FILTER_REGEX_INCLUDE` to specifically target the `flutter/craftd_widget/lib` directory for analysis.
flutter/craftd_widget/lib/presentation/ui/button/craftd_button_builder.dart
Show resolved
Hide resolved
rviannaoliveira
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests
Screenshots
Check list