-
Notifications
You must be signed in to change notification settings - Fork 1
Solving Dart Warnings #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
cc0d672
Update Android Gradle configuration and dependencies
gabrielbmoro d36786e
Strengthen Dart static analysis and configure MegaLinter
gabrielbmoro ff93d7c
Some configurations specific for dart analysis
gabrielbmoro d0e8113
Update Flutter analysis options to use `flutter_lints`
gabrielbmoro 04aec1e
feat: Add Dart analysis options
gabrielbmoro 405c957
Refactor: Standardize string literal usage
gabrielbmoro 140c6d4
Add pre-commands for Dartanalyzer
gabrielbmoro f636ba0
Remove unnecessary import
gabrielbmoro 4e7dafd
chore: MegaLinter configuration updates
gabrielbmoro e048fcf
Add pre-step to install flutter dependencies
gabrielbmoro 4a8c5e3
Some improvements
gabrielbmoro 3e3544f
Disable detekt errors to focus only on Dart issues
gabrielbmoro dceb1dd
Specific fluttter set
gabrielbmoro 1e2cad1
Setup flutter linter only for the craftD library
gabrielbmoro 048e93b
Only including craftd-widget
gabrielbmoro 8728544
Trying to specify a single location to be analyzed by megalinter
gabrielbmoro a62f106
Trying to execute as a precommand flutter pub get
gabrielbmoro f068334
Disable apply fixes
gabrielbmoro fa7f0cb
Specify the configuration file
gabrielbmoro 575bcaa
Try to specify automatically the linter rules
gabrielbmoro eb42efd
Replace default cli analyzer
gabrielbmoro 85caf66
Set Dartanalyzer include filter to flutter/craftd_widget/lib
gabrielbmoro 2ac5ce7
Remove dart analyze from Megalinter, adding an extra step for flutter
gabrielbmoro 0db7058
Create a specific workflow for flutter linter
gabrielbmoro c0014b4
Update flutter_lints dependency to version 4.0.0 in pubspec.yaml files
gabrielbmoro 4f6e00f
Format yamls
gabrielbmoro 50645c1
Solve some yaml issues
gabrielbmoro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,4 +20,5 @@ | |
## Related Issues | ||
|
||
[Add issues related to this PR, if any.] | ||
- [issue 1 link] | ||
|
||
- [issue 1 link] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
name: "Setup Flutter" | ||
description: "Reusable action to setup Flutter environment" | ||
|
||
runs: | ||
using: "composite" | ||
steps: | ||
- name: Set up Flutter | ||
uses: subosito/flutter-action@v2 | ||
with: | ||
flutter-version: "3.29.3" # Set the desired Flutter version | ||
|
||
- name: Install dependencies - CraftD Widget | ||
working-directory: flutter/craftd_widget | ||
run: flutter pub get | ||
shell: bash | ||
|
||
- name: Install dependencies - Sample | ||
working-directory: flutter/sample | ||
run: flutter pub get | ||
shell: bash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
name: Flutter linter | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up Flutter | ||
uses: ./.github/actions/setup-flutter | ||
|
||
- name: Analyze - CraftD Widget | ||
working-directory: flutter/craftd_widget | ||
run: dart analyze | ||
|
||
- name: Analyze - Sample | ||
working-directory: flutter/sample | ||
run: dart analyze |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.