chore: bump cryptography dependency and remove upper bound#821
Conversation
Greptile SummaryThis PR bumps the
|
| Filename | Overview |
|---|---|
| packages/data-designer-engine/pyproject.toml | Bumps cryptography minimum to 48.0.1, but the new upper bound <=49 (inclusive) would block 49.x patch releases; should be <50 to match the file's convention and the PR's stated intent. |
| tests_e2e/pyproject.toml | Raises constraint-dependency minimum for cryptography from 46.0.7 to 48.0.1; straightforward and correct. |
| uv.lock | Lock file updated to resolve cryptography 48.0.1 with correct hashes; no issues. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["cryptography dependency"] --> B["data-designer-engine\npyproject.toml"]
A --> C["tests_e2e\npyproject.toml"]
A --> D["uv.lock"]
B --> B1["Before: >=46.0.7,<47\nPins to 46.x only"]
B --> B2["After: >=48.0.1,<=49\n⚠️ Blocks 49.0.1+ patch releases"]
B2 --> B3["Intended: >=48.0.1,<50\nAllows full 49.x series"]
C --> C1["Before: >=46.0.7\nConstraint-dependency"]
C --> C2["After: >=48.0.1\nConstraint-dependency ✅"]
D --> D1["Resolved: 48.0.1\nHashes verified ✅"]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["cryptography dependency"] --> B["data-designer-engine\npyproject.toml"]
A --> C["tests_e2e\npyproject.toml"]
A --> D["uv.lock"]
B --> B1["Before: >=46.0.7,<47\nPins to 46.x only"]
B --> B2["After: >=48.0.1,<=49\n⚠️ Blocks 49.0.1+ patch releases"]
B2 --> B3["Intended: >=48.0.1,<50\nAllows full 49.x series"]
C --> C1["Before: >=46.0.7\nConstraint-dependency"]
C --> C2["After: >=48.0.1\nConstraint-dependency ✅"]
D --> D1["Resolved: 48.0.1\nHashes verified ✅"]
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/data-designer-engine/pyproject.toml:39
The upper bound `<=49` uses an inclusive comparison, which means any patch release of version 49 (e.g. `49.0.1`, `49.1.0`) would be excluded since those sort *greater than* `49.0.0` under PEP 440. Every other constraint in this file uses an exclusive `<N` form (e.g. `<1`, `<2`, `<6`), so the pattern here should be `<50` to allow all 49.x releases. As written, the stated goal of "not set an upper bound that blocks taking new changes" would be defeated as soon as a 49.x patch lands.
```suggestion
"cryptography>=48.0.1,<50",
```
Reviews (3): Last reviewed commit: "chore: bump cryptography dependency to a..." | Re-trigger Greptile
3ea4686 to
835a576
Compare
|
Issue #820 has been triaged. The linked issue check is being re-evaluated. |
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
835a576 to
f51f80c
Compare
| "asciichartpy>=1.5.25,<2", | ||
| "chardet>=3.0.2,<6", # Pulled in by sqlfluff | ||
| "cryptography>=46.0.7,<47", # 46.0.7 fixes CVE-2026-39892 pulled in by mcp | ||
| "cryptography>=48.0.1,<=49", |
There was a problem hiding this comment.
The upper bound
<=49 uses an inclusive comparison, which means any patch release of version 49 (e.g. 49.0.1, 49.1.0) would be excluded since those sort greater than 49.0.0 under PEP 440. Every other constraint in this file uses an exclusive <N form (e.g. <1, <2, <6), so the pattern here should be <50 to allow all 49.x releases. As written, the stated goal of "not set an upper bound that blocks taking new changes" would be defeated as soon as a 49.x patch lands.
| "cryptography>=48.0.1,<=49", | |
| "cryptography>=48.0.1,<50", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/data-designer-engine/pyproject.toml
Line: 39
Comment:
The upper bound `<=49` uses an inclusive comparison, which means any patch release of version 49 (e.g. `49.0.1`, `49.1.0`) would be excluded since those sort *greater than* `49.0.0` under PEP 440. Every other constraint in this file uses an exclusive `<N` form (e.g. `<1`, `<2`, `<6`), so the pattern here should be `<50` to allow all 49.x releases. As written, the stated goal of "not set an upper bound that blocks taking new changes" would be defeated as soon as a 49.x patch lands.
```suggestion
"cryptography>=48.0.1,<50",
```
How can I resolve this? If you propose a fix, please make it concise.
📋 Summary
🔗 Related Issue
Fixes #820
🧪 Testing
make testpasses✅ Checklist