Skip to content

theme-check validation tool for theme files #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

theme-check validation tool for theme files #69

merged 1 commit into from
Jul 17, 2025

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Jul 15, 2025 •
edited
Loading

Closes https://github.com/Shopify/developer-tools-team/issues/777
Part of https://github.com/Shopify/developer-tools-team/issues/771

  • New validation to check liquid files + supporting theme files as they are generated by the LLM
  • Any time the LLM generates liquid code, they will be run against this theme-check
  • All generated files will be grouped together as a "partial theme"
  • Theme check will run ONLY against the files generated by the LLM and not against the whole theme
  • This validation will be used by AI block gen or any time a theme dev asks to generate a block/snippet/section/component

NOTE:

  • We will not merge Liquid support until all the pieces are ready
  • This will be the base PR that we will stack and merge together

@aswamy aswamy requested a review from a team as a code owner July 15, 2025 16:24
@aswamy aswamy requested review from karreiro and EvilGenius13 July 15, 2025 16:24
@aswamy aswamy force-pushed the theme-codeblock-validation branch 2 times, most recently from 80ca626 to 58960b9 Compare July 15, 2025 20:11
@aswamy aswamy mentioned this pull request Jul 15, 2025
Merged
Arkham
Arkham reviewed Jul 16, 2025
View reviewed changes
@aswamy aswamy force-pushed the theme-codeblock-validation branch 2 times, most recently from 251f2db to a14f8d9 Compare July 16, 2025 13:59
Arkham
Arkham approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@Arkham Arkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some tiny comments but up to you if you want to address them

@aswamy aswamy force-pushed the theme-codeblock-validation branch from a14f8d9 to 32a773a Compare July 17, 2025 15:02
@aswamy aswamy merged commit 7693af0 into main Jul 17, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Aug 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkham Arkham Arkham approved these changes

@karreiro karreiro Awaiting requested review from karreiro

@EvilGenius13 EvilGenius13 Awaiting requested review from EvilGenius13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aswamy @Arkham