Skip to content

Full Theme validation #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

Full Theme validation #70

merged 1 commit into from
Jul 17, 2025

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Jul 15, 2025 •
edited
Loading

Part of https://github.com/Shopify/developer-tools-team/issues/771

Prerequisite branch: #69

  • New theme validation tool
  • This tool checks the entire theme once the LLM has modified any theme code
  • Fixes any code related to the code generated
  • Offers suggestion on code that is also broken but isn't directly related to the generated code

@aswamy aswamy requested a review from a team as a code owner July 15, 2025 20:19
@aswamy aswamy requested review from karreiro and EvilGenius13 July 15, 2025 20:19
@aswamy aswamy force-pushed the theme-codeblock-validation branch 2 times, most recently from 251f2db to a14f8d9 Compare July 16, 2025 13:59
@aswamy aswamy force-pushed the full-theme-validation branch from 2e870f2 to 88a9c72 Compare July 16, 2025 14:06
@aswamy aswamy mentioned this pull request Jul 17, 2025
Closed
Arkham
Arkham approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@Arkham Arkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aswamy aswamy force-pushed the theme-codeblock-validation branch from a14f8d9 to 32a773a Compare July 17, 2025 15:02
@aswamy aswamy force-pushed the full-theme-validation branch from 88a9c72 to 0ecbffe Compare July 17, 2025 18:24
@aswamy aswamy changed the base branch from theme-codeblock-validation to main July 17, 2025 18:24
@aswamy aswamy force-pushed the full-theme-validation branch from 0ecbffe to 6e23884 Compare July 17, 2025 18:25
@aswamy aswamy force-pushed the full-theme-validation branch from 6e23884 to 9b4d7f2 Compare July 17, 2025 18:42
@aswamy aswamy merged commit 0d4d74b into main Jul 17, 2025
7 of 14 checks passed
@aswamy
Copy link
Contributor Author

aswamy commented Jul 17, 2025

/snapit

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @aswamy! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/dev-mcp": "0.0.0-snapshot-20250717202233"

@github-actions github-actions bot mentioned this pull request Aug 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkham Arkham Arkham approved these changes

@EvilGenius13 EvilGenius13 EvilGenius13 approved these changes

@karreiro karreiro Awaiting requested review from karreiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aswamy @Arkham @EvilGenius13