feat(console): remove hardcoded 10k input character limit#5675
Closed
vinaychauhannumber wants to merge 1 commit into
Closed
feat(console): remove hardcoded 10k input character limit#5675vinaychauhannumber wants to merge 1 commit into
vinaychauhannumber wants to merge 1 commit into
Conversation
Modern LLMs natively support 256k–1M+ token context windows. Capping the chat input box at 10,000 characters forces users to split long texts into files or multiple messages, breaking the copy-paste workflow for heavy users (developers, researchers, etc.). Removing sender.maxLength from defaultConfig lets the underlying Sender component accept input of any length, matching the actual capacity of the configured model. Closes agentscope-ai#5670
|
Hi @vinaychauhannumber, thank you for your first Pull Request! 🎉 🙌 Join Developer CommunityThanks so much for your contribution! We'd love to invite you to join the official QwenPaw developer group! You can find the Discord and DingTalk group links under the "Developer Community" section on our docs page: We truly appreciate your enthusiasm—and look forward to your future contributions! 😊 We'll review your PR soon. |
Member
|
Long text (10k+) will be supported by converting to file upload format in PR #5854 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Removes the hardcoded
sender.maxLength: 10000fromdefaultConfig.ts.Problem (Fixes #5670):
Modern LLMs natively support context windows of 256 k–1 M+ tokens. A hard 10,000-character cap in the input box forces users to:
This is especially painful for the target users mentioned in the issue: developers, researchers, and heavy office users.
Fix:
sender.maxLengthis removed from the default config object inconsole/src/pages/Chat/OptionsPanel/defaultConfig.ts.The underlying Sender component (from
@agentscope-ai/chat) imposes nolimit when the field is absent, so input length is now bounded only by what
the chosen model can actually accept — not by an arbitrary UI constant.
A comment is left in place of the removed line to explain the intent for future
maintainers.
Type of Change
Component(s) Affected
Checklist
pre-commit run --all-fileslocally and it passesTesting
Before: Typing or pasting more than 10,000 characters into the chat input box was blocked / truncated by the Sender component.
After: The chat input box accepts text of any length. Input is limited only by the model's actual context window.
Manual verification steps:
qwenpaw app, then http://127.0.0.1:8088)Closes #5670