-
Notifications
You must be signed in to change notification settings - Fork 247
feat(node-api): node syncing api #2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2693 +/- ##
==========================================
- Coverage 60.64% 60.64% -0.01%
==========================================
Files 354 355 +1
Lines 16673 16685 +12
==========================================
+ Hits 10111 10118 +7
- Misses 5773 5779 +6
+ Partials 789 788 -1
🚀 New features to boost your workflow:
|
I wanted to investigate why e2e tests are failing on the build (without any changes in PR related to kurtosis or e2e testing as of now), so wanted to run the tests locally on my machine to see if the behaviour is same across. |
811aa8e
to
c0d04ab
Compare
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
f39f300
to
6ea6091
Compare
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Was able to fix the E2E issue where tests were not starting. Now getting assertion error in staking test
When running it on local machine, all the tests runs fine. |
Signed-off-by: nidhi-singh02 <[email protected]>
|
||
// GetCometNode returns the concrete CometBFT node. | ||
func (s *Service) GetCometNode() *node.Node { | ||
return s.node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we rename this consensusInstance
or something like that?
baseHeight := blockStore.Base() | ||
|
||
response := nodetypes.SyncingData{ | ||
HeadSlot: latestHeight, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would comment here that this relays on the fact that there is a one to one matching among comet blocks and payloads. Should this ever change in the future, this would not be correct anymore
IsOptimistic: true, | ||
ELOffline: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how do we set these data by only looking at CometBFT.
In fact all of these data seems to me related to beaconKit state only.
Even the isSyncing quantity can be stored in `consensus/cometbft/service object by only looking at the SyncingToHeight attribute in FinalizeBlockRequest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me the content of this API should be served by looking at BeaconKit data only, not querying cometBFT
Node Syncing endpoint implemented along with E2E tests.
https://ethereum.github.io/beacon-APIs/?urls.primaryName=v3.1.0#/Node/getSyncingStatus