Skip to content

Use buttonsArea, UI cleanup#5013

Merged
markotoplak merged 135 commits into
biolab:masterfrom
irgolic:refactor-to-buttonsArea
Feb 26, 2021
Merged

Use buttonsArea, UI cleanup#5013
markotoplak merged 135 commits into
biolab:masterfrom
irgolic:refactor-to-buttonsArea

Conversation

@irgolic

@irgolic irgolic commented Oct 2, 2020

Copy link
Copy Markdown
Member

To be merged after biolab/orange-widget-base#130 is merged and released.

Description of changes

This PR moves some auto_commit buttons, and data projection controls, from controlArea to buttonsArea. With the widget-base PR, this is displayed below a scrollable controlArea, making it always visible.

Also, widget UIs are redesigned to be more consistent. All widgets except based only in mainArea were moved to controlArea (except Venn Diagram).

Includes
  • Code changes
  • Tests
  • Documentation

@codecov

codecov Bot commented Oct 2, 2020

Copy link
Copy Markdown

Codecov Report

Merging #5013 (f7ae05d) into master (269e2a1) will decrease coverage by 0.01%.
The diff coverage is 95.01%.

@@            Coverage Diff             @@
##           master    #5013      +/-   ##
==========================================
- Coverage   85.36%   85.34%   -0.02%     
==========================================
  Files         301      301              
  Lines       61838    61779      -59     
==========================================
- Hits        52786    52726      -60     
- Misses       9052     9053       +1     

@irgolic

irgolic commented Oct 2, 2020

Copy link
Copy Markdown
Member Author

I only went over widgets who explicitly override buttons_area_orientation. However, that option defaulted to Qt.Horizontal, so I'll take a closer look to see if there's other widgets which should be fixed. The way biolab/orange-widget-base#102 deprecates the GUI layout setting though, it should be fine.

Some mini issues:

OWSilhouettePlot, OWRank: why is controlArea slightly smaller in width than buttonsArea (on Mac)? When I try to debug this by setting a 'background: red;' stylesheet, the problem disappears. What a heisenbug.

OWContinuize: After moving it down, the 'Apply Automatically' button is gigantic. Moving it below the options is definitely better, but its width needs to be constrained. Perhaps a max width should be set if want_main_area is False?

@irgolic
irgolic force-pushed the refactor-to-buttonsArea branch 2 times, most recently from dcab8e6 to 2f72038 Compare October 2, 2020 21:37
@irgolic
irgolic marked this pull request as draft October 2, 2020 22:28
@irgolic
irgolic force-pushed the refactor-to-buttonsArea branch from 2f72038 to 4630608 Compare October 4, 2020 16:23
@irgolic
irgolic force-pushed the refactor-to-buttonsArea branch from 4630608 to 2ceeda2 Compare October 4, 2020 16:25
@irgolic
irgolic force-pushed the refactor-to-buttonsArea branch from 2ceeda2 to 9dd6e78 Compare January 29, 2021 10:45
@irgolic
irgolic marked this pull request as ready for review January 29, 2021 10:46
@irgolic irgolic added the waiting for new dependency version Depends on unreleased orange-canvas-core/orange-widget-base content label Jan 29, 2021
@irgolic
irgolic force-pushed the refactor-to-buttonsArea branch from b00e543 to 3cdde71 Compare February 1, 2021 16:40
@markotoplak markotoplak added this to the 3.28.0 milestone Feb 1, 2021
@irgolic

irgolic commented Feb 3, 2021

Copy link
Copy Markdown
Member Author

Due to biolab/orange-widget-base#127, this will need to be adjusted to retain the gui.rubbers in the controlArea.

Edit: nevermind

@irgolic
irgolic force-pushed the refactor-to-buttonsArea branch from 3cdde71 to ec5c983 Compare February 8, 2021 03:26
@irgolic irgolic changed the title Move auto_commit buttons from controlArea to buttonsArea Use buttonsArea, UI cleanup Feb 8, 2021
@irgolic
irgolic force-pushed the refactor-to-buttonsArea branch from ec5c983 to 16d909d Compare February 10, 2021 19:52
@janezd janezd assigned markotoplak and janezd and unassigned markotoplak and janezd Feb 12, 2021
@irgolic
irgolic force-pushed the refactor-to-buttonsArea branch 6 times, most recently from 5ee6b8d to 157670b Compare February 19, 2021 01:13
@irgolic irgolic mentioned this pull request Feb 19, 2021
3 tasks
@irgolic irgolic removed the waiting for new dependency version Depends on unreleased orange-canvas-core/orange-widget-base content label Feb 19, 2021
@irgolic
irgolic force-pushed the refactor-to-buttonsArea branch from 2185954 to f7ae05d Compare February 26, 2021 09:46
@markotoplak
markotoplak merged commit 61f7d5c into biolab:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants