Feature/tanstack db #582
Open
Feature/tanstack db #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/tanstack-db
LemonardoD
reviewed
Aug 8, 2025
| @@ -44,71 +45,112 @@ export const groupedAttachmentsQueryOptions = ({ | |||
| }); | |||
|
|
|||
| //TODO (TanStackDB) make optimistic updates work offline | |||
| export const getAttachmentsCollection = (organizationId: string): Collection<LiveQueryAttachment> => { | |||
| export const getAttachmentsCollection = ( | |||
There was a problem hiding this comment.
If create mutations through createTransaction ( to be able create hook for offline updates) get same err in usage of raw
const attachmentsCollection = getAttachmentsCollection(orgIdOrSlug)
I must add attachmentsCollection.startImidietSync()
LemonardoD
reviewed
Aug 8, 2025
| @@ -103,6 +112,18 @@ const BaseDataTable = memo( | |||
| // Effect to update total and selected rows when data changes | |||
| useEffect(() => setTotal(combined.length), [combined]); | |||
|
|
|||
| //TODO (TanStackDB) make work with Strict mode | |||
There was a problem hiding this comment.
Can't make it work proper in dev with strict mode, mb there is the better way to abort on offline and unmount for colletion?
LemonardoD
reviewed
Aug 8, 2025
| @@ -26,7 +26,7 @@ const BaseDataTable = memo( | |||
| const attachmentCollection = getAttachmentsCollection(orgIdOrSlug); | |||
| const localAttachmentCollection = getLocalAttachmentsCollection(orgIdOrSlug); | |||
|
|
|||
| //TODO (TanStackDB) reduse re-renders will fix (ERR_INSUFFICIENT_RESOURCES) | |||
| //TODO (TanStackDB) Add drop of sync on component unmount | |||
There was a problem hiding this comment.
Re-renders re-trigger live query with sync, causes a lot of query fire up at the same time on initial load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.