Skip to content

Feature/tanstack db #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: development
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/modules/attachments/table/table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const BaseDataTable = memo(
const attachmentCollection = getAttachmentsCollection(orgIdOrSlug);
const localAttachmentCollection = getLocalAttachmentsCollection(orgIdOrSlug);

//TODO (TanStackDB) reduse re-renders will fix (ERR_INSUFFICIENT_RESOURCES)
//TODO (TanStackDB) Add drop of sync on component unmount
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-renders re-trigger live query with sync, causes a lot of query fire up at the same time on initial load

const { data, isLoading } = useLiveQuery(
(query) => {
let qBuilder = query.from({ attachments: attachmentCollection });
Expand Down