ci: bump golangci-lint to v1.50.1 #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
force-pushed
the
pr/rolinh/ci-bump-golangci-lint
branch
2 times, most recently
from
eb58ea4 to
0b31d33
Compare
willfindlay
approved these changes
Dec 9, 2022
rolinh
force-pushed
the
pr/rolinh/ci-bump-golangci-lint
branch
from
0b31d33 to
cc5a290
Compare
|
More struggle, needs a |
rolinh
force-pushed
the
pr/rolinh/ci-bump-golangci-lint
branch
from
cc5a290 to
d2d8c82
Compare
We now use Go v1.18, there is not reason to use the Go v1.17 compatibility mode anymore. Signed-off-by: Robin Hahling <[email protected]>
rolinh
force-pushed
the
pr/rolinh/ci-bump-golangci-lint
branch
from
d2d8c82 to
7a37f96
Compare
The `varcheck` linter has been removed as it is unmaintained. Also bump the golangci-lint action to v3.3.1. Use the new `skip-cache` directive to disable caching instead of the more specific options. Remove `only-new-issues: false` given that `false` is the default value. Finally, remove `skip-go-installation` as this is an unknown config option to the linter which gives a warning. Signed-off-by: Robin Hahling <[email protected]>
rolinh
force-pushed
the
pr/rolinh/ci-bump-golangci-lint
branch
from
7a37f96 to
b633f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump the golangci-lint action to v3.3.1. Use the new
skip-cachedirective to disable caching instead of the more specific options. Removeonly-new-issues: falsegiven thatfalseis the default value. Finally, removeskip-go-installationas this is an unknown config option to the linter which gives a warning.