Skip to content

Adding c10s repo #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding c10s repo #837

wants to merge 2 commits into from

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Jun 3, 2025

resolve #828

Fixing .packit.yaml indenentations

Summary by Sourcery

Introduce CentOS Stream 10 repository in Packit configuration, update CI job targets and fix YAML indentations, and enhance test scripts robustness.

Enhancements:

  • Add &bluechi_copr_repo_c10s alias for CentOS Stream 10 in .packit.yaml and update jobs to reference both c9s and c10s repositories
  • Add epel-10-x86_64 targets and bump Fedora version to 42 in CI jobs
  • Parameterize disk lock size in ffi disk test via LOCK_DISK_SPACE environment variable
  • Improve test scripts by waiting for bluechi-agent.service to be online before stopping and fixing podman exec quoting in journal socket check

@Yarboa Yarboa self-assigned this Jun 3, 2025
Copy link
Contributor

sourcery-ai bot commented Jun 3, 2025

Reviewer's Guide

This PR refactors the .packit.yaml configuration to standardize and extend c10s copr repository anchors (adding centos-stream-10), fixes YAML indentation across jobs, updates test matrix targets (introducing epel-10 and bumping Fedora from 41 to 42), and enhances several FFI test scripts with service checks and parameterized disk allocation.

Class diagram for standardized repository anchors in .packit.yaml

classDiagram
    class BluechiCoprRepoC9S {
        +type: repository-file
        +id: "https://copr.fedorainfracloud.org/coprs/g/centos-automotive-sig/bluechi-snapshot/repo/centos-stream-9"
    }
    class BluechiCoprRepoC10S {
        +type: repository-file
        +id: "https://copr.fedorainfracloud.org/coprs/g/centos-automotive-sig/bluechi-snapshot/repo/centos-stream-10"
    }
    class BluechiCoprRepoFedora {
        +type: repository-file
        +id: "https://copr.fedorainfracloud.org/coprs/g/centos-automotive-sig/bluechi-snapshot/repo/fedora"
    }
    class Environment {
        +artifacts: list
        +hardware: object
    }
    Environment "1" -- "*" BluechiCoprRepoC9S : uses
    Environment "1" -- "*" BluechiCoprRepoC10S : uses
    Environment "1" -- "*" BluechiCoprRepoFedora : uses
Loading

File-Level Changes

Change Details Files
Standardize and extend c10s copr repository anchors
  • Renamed &bluechi_copr_repo to &bluechi_copr_repo_c9s
  • Added &bluechi_copr_repo_c10s entry with correct repo URL
  • Replaced all *bluechi_copr_repo references with *bluechi_copr_repo_c9s and *bluechi_copr_repo_c10s
.packit.yaml
Update test matrix targets
  • Added epel-10-x86_64 to targets in multiple test jobs
  • Bumped Fedora target from fedora-41 to fedora-42 in kvm-tier-0 plan
.packit.yaml
Fix YAML indentation and formatting in .packit.yaml
  • Aligned artifacts list items under environments
  • Corrected nested hardware.disk indentation
  • Fixed tmt.scenario key formatting
  • Adjusted virtualization.is-supported indentation
.packit.yaml
Enhance FFI test scripts for service readiness and disk handling
  • Wait for bluechi-agent.service to be online before stopping in agent-flood test
  • Wrap podman exec stat in sh -c for journal socket check
  • Introduce LOCK_DISK_SPACE variable and use in fallocate command
tests/ffi/agent-flood/test.sh
tests/ffi/attempts_to_access_forbidden_file_system_resource/sockets/check_run_systemd_journal_socket.sh
tests/ffi/disk/test.sh

Assessment against linked issues

Issue Objective Addressed Explanation
#828 Add CentOS 10 (epel-10-x86_64) as a target in CI/CD tests to ensure the package is tested on CentOS 10.
#828 Update CI/CD configuration to use the CentOS 10 repository for testing.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Yarboa
Copy link
Collaborator Author

Yarboa commented Aug 5, 2025

/packit build --commit main

@Yarboa
Copy link
Collaborator Author

Yarboa commented Aug 5, 2025

/packit build

@Yarboa Yarboa force-pushed the c10s branch 4 times, most recently from 96746ad to 0ea94d9 Compare August 11, 2025 13:27
resolve containers#828

Fixing .packit.yaml indenentations

Signed-off-by: Yariv Rachmani <[email protected]>
@Yarboa Yarboa force-pushed the c10s branch 2 times, most recently from 7c70f79 to 3773574 Compare August 12, 2025 18:22
LOCK_DISK_SPACE could be configured for c10s
Takes more then 10m to finish
Adding c10 condition to execute set-ffi-env-e2e
script for creating diskpartition

Signed-off-by: Yariv Rachmani <[email protected]>
@Yarboa
Copy link
Collaborator Author

Yarboa commented Aug 17, 2025

@dougsland I assume it is ready

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • In kvm-tier-0 under the Fedora target you only reference the c9s and Fedora anchors—consider adding the c10s anchor if you intend to test centos-stream-10 there.
  • The new timeout check in tests/ffi/agent-flood/test.sh lacks a failure path—add an else branch to exit with error when bluechi-agent.service never comes online.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In kvm-tier-0 under the Fedora target you only reference the c9s and Fedora anchors—consider adding the c10s anchor if you intend to test centos-stream-10 there.
- The new timeout check in tests/ffi/agent-flood/test.sh lacks a failure path—add an else branch to exit with error when bluechi-agent.service never comes online.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CentOS 10: Add into the CI/CD tests
1 participant