-
Notifications
You must be signed in to change notification settings - Fork 35
Adding c10s repo #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding c10s repo #837
Conversation
Reviewer's GuideThis PR refactors the .packit.yaml configuration to standardize and extend c10s copr repository anchors (adding centos-stream-10), fixes YAML indentation across jobs, updates test matrix targets (introducing epel-10 and bumping Fedora from 41 to 42), and enhances several FFI test scripts with service checks and parameterized disk allocation. Class diagram for standardized repository anchors in .packit.yamlclassDiagram
class BluechiCoprRepoC9S {
+type: repository-file
+id: "https://copr.fedorainfracloud.org/coprs/g/centos-automotive-sig/bluechi-snapshot/repo/centos-stream-9"
}
class BluechiCoprRepoC10S {
+type: repository-file
+id: "https://copr.fedorainfracloud.org/coprs/g/centos-automotive-sig/bluechi-snapshot/repo/centos-stream-10"
}
class BluechiCoprRepoFedora {
+type: repository-file
+id: "https://copr.fedorainfracloud.org/coprs/g/centos-automotive-sig/bluechi-snapshot/repo/fedora"
}
class Environment {
+artifacts: list
+hardware: object
}
Environment "1" -- "*" BluechiCoprRepoC9S : uses
Environment "1" -- "*" BluechiCoprRepoC10S : uses
Environment "1" -- "*" BluechiCoprRepoFedora : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
/packit build --commit main |
/packit build |
96746ad
to
0ea94d9
Compare
resolve containers#828 Fixing .packit.yaml indenentations Signed-off-by: Yariv Rachmani <[email protected]>
7c70f79
to
3773574
Compare
LOCK_DISK_SPACE could be configured for c10s Takes more then 10m to finish Adding c10 condition to execute set-ffi-env-e2e script for creating diskpartition Signed-off-by: Yariv Rachmani <[email protected]>
@dougsland I assume it is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- In kvm-tier-0 under the Fedora target you only reference the c9s and Fedora anchors—consider adding the c10s anchor if you intend to test centos-stream-10 there.
- The new timeout check in tests/ffi/agent-flood/test.sh lacks a failure path—add an else branch to exit with error when bluechi-agent.service never comes online.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In kvm-tier-0 under the Fedora target you only reference the c9s and Fedora anchors—consider adding the c10s anchor if you intend to test centos-stream-10 there.
- The new timeout check in tests/ffi/agent-flood/test.sh lacks a failure path—add an else branch to exit with error when bluechi-agent.service never comes online.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
resolve #828
Fixing .packit.yaml indenentations
Summary by Sourcery
Introduce CentOS Stream 10 repository in Packit configuration, update CI job targets and fix YAML indentations, and enhance test scripts robustness.
Enhancements: