Skip to content

misc: remove centos image from image conversion CI #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Mar 24, 2025

The centos image has been deprecated on Docker Hub, so we can't pull it in "Convert & Check Images" CI pipeline.

See https://hub.docker.com/_/centos

The broken CI: https://github.com/dragonflyoss/nydus/actions/runs/14024645226

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

The centos image has been deprecated on Docker Hub, so we can't
pull it in "Convert & Check Images" CI pipeline.

See https://hub.docker.com/_/centos

Signed-off-by: Yan Song <[email protected]>
@imeoer imeoer requested a review from a team as a code owner March 24, 2025 12:44
@imeoer imeoer requested review from gaius-qi, changweige and adamqqqplay and removed request for a team March 24, 2025 12:44
The output bootstrap path has been changed in the nydusify
check subcommand.

Related PR: dragonflyoss#1652

Signed-off-by: Yan Song <[email protected]>
@imeoer imeoer requested a review from a team as a code owner March 25, 2025 02:26
@imeoer imeoer requested review from BraveY and removed request for a team March 25, 2025 02:26
Copy link

@BraveY BraveY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BraveY BraveY merged commit 8c0925b into dragonflyoss:master Mar 25, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants