Skip to content

Modify scavenger GC count follow up #7830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

adpopescu
Copy link
Contributor

@adpopescu adpopescu commented Jul 8, 2025

Currently, scavengerStats gcCount counts the number of increments.
This change modifies it to count the number of cycles instead.

This change should be merged after eclipse-openj9/openj9#22180.

@adpopescu adpopescu marked this pull request as ready for review July 10, 2025 15:04
@adpopescu
Copy link
Contributor Author

@amicic

@adpopescu adpopescu force-pushed the jfr-gc-events branch 2 times, most recently from 776f195 to 29ea476 Compare July 10, 2025 18:55
@amicic
Copy link
Contributor

amicic commented Jul 11, 2025

@babsingh please, review/merge

@babsingh
Copy link
Contributor

There is a constraint on the char limit per line in the commit message: https://github.com/eclipse-omr/omr/blob/master/CONTRIBUTING.md#commit-guidelines

The body should be wrapped at 72 characters, where reasonable.

Currently, the above requirement is not met.

Currently, scavengerStats gcCount counts the number of increments.
This change moves it so it counts the number of cycles instead.

Signed-off-by: Adrian Popescu <[email protected]>
@babsingh
Copy link
Contributor

jenkins build all

@babsingh babsingh merged commit 75e9aa1 into eclipse-omr:master Jul 11, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants